Draft
Conversation
Contributor
|
Oh wow, just saw this--really cool 8) |
r1viollet
force-pushed
the
r1viollet/python_frames_v2
branch
from
e8b6cce to
f4b4821
Compare
Fix the build time dependency to read internal python frames from register state
Adjust the logics to cache python frames
I added a minor cache on the registers that yield valid results.
- Avoid ending profiling when non utf8 strings are found - Other fixups to investigate libaustin issue
r1viollet
force-pushed
the
r1viollet/python_frames_v2
branch
from
f8d102f to
383e076
Compare
r1viollet
force-pushed
the
r1viollet/python_frames_v2
branch
from
b294a1b to
156abae
Compare
Adjust the log to be more comprehensive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prototype using libaustin to include information on python frames.
This uses
vm_readsso requires ptrace capabilities.The method to lookup frames is really experimental:
Limitations
The build parts are not sorted out yet
.afrom libaustin is not propagated correctly. I manually built it and copied it on ubuntu 20 for agent investigations from the libaustin branch.The synchronisation is not perfect.
By the time we get the event, python may have done a lot of things (frames can get reused). This gives us messy frames (they do not aggregate well).
This takes some amount of CPU. We need to perform a lookup quite often.
Licensing
This is probably the most complex topici.